[Savestates] Attempt at fixing velocity being reset on loadstate #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still trying to fix player movement after savestate
|
NEVER GIVE UP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One tick after a loadstate, the velocity of the player will be reset for one tick, which desyncs the rest of the TAS.
I was able to trace the issue back to the NetHandlerPlayServer, where the player is processed. If the player is not added to the chunk on the server side, a collision check with the nearest block would fail (kinda like walking into unloaded chunks) and the velocity would be reset to 0, which would then get sent to the client.
To fix this, I add the player to yet another chunk variable. Hopefully this will not bite me in the future